Skip to content

Jesse and Jane Video Store API #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JaneEdwMcN wants to merge 95 commits into
base: master
Choose a base branch
from
Open

Jesse and Jane Video Store API #17

JaneEdwMcN wants to merge 95 commits into from

Conversation

@JaneEdwMcN
Copy link

@JaneEdwMcN JaneEdwMcN commented Nov 9, 2018

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question Answer
Explain how you came up with the design of your ERD, based on the seed data. We named our columns after the fields in the seed data.
What would be the Big-O time complexity of your /customers & /movies endpoints? What does the time complexity depend on? Explain your reasoning. It would be O(n) because for the two methods this question is possibly referring to (movies/index and customers/index) we are collecting all of the Customer and Movie instances.
What is the Big-O time complexity of the POST /rentals/check-in endpoint? What does the time complexity depend on? Explain your reasoning. We used find_by. We are not sure of the time complexity because there is no officially maintained list of time complexity for Ruby built in methods. We would guess linear because we are searching in some kind of array.
Describe a set of positive and negative test cases you implemented for a model. We tested validations with valid data and invalid data.
Describe a set of positive and negative test cases you implemented for a controller. We tested pagination for valid and invalid input.
How does your API respond when bad data is sent to it? It sends an error message.
Describe one of your custom model methods and why you chose to wrap that functionality into a method. We created check_in and check_out methods in movies and customers models to try to separate concerns when checking in and out rentals.
Do you have any recommendations on how we could improve this project for the next cohort? Reinforce the vocabulary for the word "endpoint". Less optional stuff. We enjoy doing optionals, but these seemed excessive.
Link to Trello https://trello.com/b/w4K6VAHW/jesse-and-jane-video-store-board
Link to ERD https://www.lucidchart.com/invitations/accept/1649d72f-3972-4fd3-8ee8-04289777539f
Summary

jessiezhang2017 and others added 30 commits November 5, 2018 11:26
@jessiezhang2017
create rail project
3e2f010
@JaneEdwMcN
Update README.md
b7d8599
@JaneEdwMcN
Update README.md
e279db6
@JaneEdwMcN
Update README.md
d99a93f
@jessiezhang2017
created controllers
0c6d553
@jessiezhang2017
Merge branch 'master' of https://github.com/jessiezhang2017/VideoStor…
c8a105e 
…eAPI
@JaneEdwMcN
added models for Customer, Rental, and Movie
e8c9490
@JaneEdwMcN
added relationships to models
093b182
@jessiezhang2017
moved foregin key from movie to rental
ca569f2
@JaneEdwMcN
added markdown file for pseudo-coded routes
7d1e929
@JaneEdwMcN
added pseudo code routes for movies, check-in, check-out
2326359
@jessiezhang2017
complete the pseudo code routes
c70d3f2
@JaneEdwMcN
created routes
fec0a7a
@JaneEdwMcN
created routes
b340e8a
@JaneEdwMcN
added failed zomg route and method
6928129
@jessiezhang2017
fixed the zomg action in controller
d7e263f
@jessiezhang2017
remove string field fm customer, added fixtures for test
62b177d
@JaneEdwMcN
added validations to rentals and customers
351aaa0
@JaneEdwMcN
added relationship tests and fixed line in test_helper.rb
53af761
@JaneEdwMcN
added more tests for rental model
7c65d13
@JaneEdwMcN
added customer model tests
e9d4a1f
@jessiezhang2017
set up default values
78fcf90
@jessiezhang2017
updated the movie model test
3d7c7c2
@JaneEdwMcN
added customers API call and index method and tests for controller
7ad8bb1
@jessiezhang2017
added test for movie index action
08210b0
@jessiezhang2017
resolve merge conflect
b084c8d
@JaneEdwMcN
added movie create and tests
c672b43
@JaneEdwMcN
fixed merge conflicts
165fe0a
@jessiezhang2017
added test for movie show action
f319b0f
@JaneEdwMcN
made create pass smoke test
ed80269
JaneEdwMcN and others added 30 commits November 7, 2018 20:24
@JaneEdwMcN
deleted an empty line
83abe54
@JaneEdwMcN
added current method to customers to list the movies a customer curre…
36aeb19 
…ntly has checked out
@JaneEdwMcN
completed current method that lists the movies a customer has checked…
2942214 
… out in the past
@JaneEdwMcN
added find_customer method to Customers controller
e1c2758
@jessiezhang2017
udpated the current customer method
a556e1c
@jessiezhang2017
merge conflict
36121f1
@JaneEdwMcN
fixed find_customer method
4efd4be
@JaneEdwMcN
Merge branch 'see_about_moving_some_logic_to_models'
abc71c7
@jessiezhang2017
udpated current customer action in movie
05f42b3
@JaneEdwMcN
rewrote current and history (customers) with new logic
20e18b1
@jessiezhang2017
updated the current customer action in movie
c2c0a01
@jessiezhang2017
Merge branch 'master' of https://github.com/jessiezhang2017/VideoStor…
3f7df37 
…eAPI
@jessiezhang2017
changed the current and history action for movie
e99f27d
@JaneEdwMcN
moved helper methods to Customer model for index, current, and history
25fe8e9
@JaneEdwMcN
readded missing methods
b03bd8c
@JaneEdwMcN
added .class to methods to fix errors
cf8ea98
@JaneEdwMcN
added Rental model tests
67a1c67
@JaneEdwMcN
set up tests for Rentals controller
233792e
@jessiezhang2017
updated current and history action for movie
d3d9fa9
@jessiezhang2017
resolve conflict
641ab56
@jessiezhang2017
dry movie controller actions
a49c79e
@jessiezhang2017
added movie controller test & model test
8f42492
@JaneEdwMcN
adding rental tests
affccce
@JaneEdwMcN
fixed merge conflict in rental fixtures
c3e2bd0
@JaneEdwMcN
completed rental controller tests
aac2316
@JaneEdwMcN
deleted a couple unused lines
c08cd2a
@JaneEdwMcN
completed customer controller tests
acdcc04
@JaneEdwMcN
fixed test
82dc121
@jessiezhang2017
fixed the test
ffb565f
@jessiezhang2017
Merge branch 'test5'
ec14516
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JaneEdwMcN @jessiezhang2017